DATAGO-105493: Integration test to support optional nodeport configuration #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstream-cm[bot]](https://avatars.githubusercontent.com/in/230441?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Please mark whether you used Copilot to assist coding in this PR
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.github/workflows/test-nodeport.yml
Outdated
Comment on lines
109
to
113
| kubectl port-forward svc/test-nonha-nodeport-pubsubplus 55555:55555 & | ||
| sleep 5 | ||
| curl -O https://sftp.solace.com/download/SDKPERF_C_LINUX64 | ||
| tar -xvf SDKPERF_C_LINUX64 | ||
| pubSubTools/sdkperf_c -cip=tcp://localhost:55555 -mn=1000 -mr=0 -ptl=t1 -stl=t1 | grep "Total Messages" |
There was a problem hiding this comment.
@LewisKSaint have you reviewed this?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
hossein-ashraf-kashani
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://sol-jira.atlassian.net/browse/DATAGO-105493
Description
nodePort, this is optionalNodePortwith nonodePortconfiguration, random node ports will be assignednodePortare used, broker configuration will use that.Anything for reviewers to be aware of
nodePortconfiguration. With the random port allocation, there will be no port collision✨ PR Description
Purpose: Add NodePort support to PubSubPlus EventBroker with configurable fixed ports to enable direct access to broker services.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀